Skip to content

Fix proguard rules #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Fix proguard rules #2273

merged 1 commit into from
Oct 1, 2020

Conversation

dkhalanskyjb
Copy link
Collaborator

Solves #2046 and
#2266.

I tested these issues separately, reproduced both problems and checked that this edit solves them, but I'm not sure whether we should also test for this. Maybe make the example Android projects part of the build conditionally?

@qwwdfsad qwwdfsad self-requested a review September 30, 2020 09:47
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elizarov elizarov merged commit d2ed1d8 into develop Oct 1, 2020
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
@qwwdfsad qwwdfsad deleted the fix-proguard branch January 27, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants